This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFC][PATCH 01/15] Fix endian problem for tracepoint enabled flag
- From: "Wallin, Henrik" <Henrik dot Wallin at windriver dot com>
- To: Pedro Alves <palves at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 29 Oct 2015 17:49:18 +0000
- Subject: RE: [RFC][PATCH 01/15] Fix endian problem for tracepoint enabled flag
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1444820235 dot git dot henrik dot wallin at windriver dot com> <c6583915ec9ce800b88769723b49d0d1ad394863 dot 1444820235 dot git dot henrik dot wallin at windriver dot com>,<561FDF54 dot 1020306 at redhat dot com>
2015-10-15 19:16 GMT+02:00 Pedro Alves <palves@redhat.com>:
> On 10/14/2015 12:14 PM, henrik.wallin@windriver.com wrote:
>> From: Par Olsson <par.olsson@windriver.com>
>>
>> When running big endian machines there is a problem with
>> the enabled flag for tracepoints as it is defined as a
>> int8_t but written from gdbserver as an integer and then
>> read in the agent as 8-bit value.
>> This caused problem when tracepoint was disabled and
>> re-enabled.
>>
>> gdb/gdbserver/ChangeLog:
>>
>> * tracepoint.c (struct tracepoint): Change type of enabled.
>
> Seems wasteful for no obvious reason. Why not make gdbserver write
> one byte then?
I guess this was the easy fix... I will change the write instead.
thanks,
/ Henrik