This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Type-safe wrapper for enum flags
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 30 Oct 2015 15:44:44 +0000
- Subject: Re: [PATCH] Type-safe wrapper for enum flags
- Authentication-results: sourceware.org; auth=none
- References: <1446144341-21267-1-git-send-email-palves at redhat dot com> <56337B95 dot 6070809 at ericsson dot com> <56338435 dot 6080703 at redhat dot com> <56338FA1 dot 2060300 at ericsson dot com>
On 10/30/2015 03:41 PM, Simon Marchi wrote:
> On 15-10-30 10:52 AM, Pedro Alves wrote:
>> Looks like c-lang.h should include common/enum_flags.h.
>
> Good point. Include What You Use.
It should be included in the .h file, IMO. Otherwise, if
anything includes c-lang.h that doesn't happen to pull in
enum_flags.h already, it'll break.
>
>> Otherwise LGTM.
>>
>> I'd like to collect at least one Ack on the enum flags patch
>> before pushing it.
>
> Here is the patch with the include. When it's time to push your patch,
> can you make this one follow?
Sure thing. I'll put it in the C++ branch meanwhile.
I'll take care of the moving the include.
Thanks,
Pedro Alves