This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Cc: gdb-patches at sourceware dot org, koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Date: Mon, 2 Nov 2015 21:41:34 +0100 (CET)
- Subject: Re: [PATCH 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit.
- Authentication-results: sourceware.org; auth=none
Marcin KoÃ?cielnicki <koriakin at 0x04 dot net> wrote:
> +static int
> +s390_is_partial_instruction (CORE_ADDR loc, int *len)
> +{
> + uint16_t insn;
> +
> + insn = read_memory_integer (loc, 2, BFD_ENDIAN_BIG);
See the comment in the other patch about avoiding hard-coding
BFD_ENDIAN_BIG ...
As mentioned, it would be preferable to enable this only
when recording is on.
Otherwise, this patch looks good.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com