This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit.


Marcin KoÃ?cielnicki <koriakin at 0x04 dot net> wrote:

> +static int
> +s390_is_partial_instruction (CORE_ADDR loc, int *len)
> +{
> +  uint16_t insn;
> +
> +  insn = read_memory_integer (loc, 2, BFD_ENDIAN_BIG);

See the comment in the other patch about avoiding hard-coding
BFD_ENDIAN_BIG ...

As mentioned, it would be preferable to enable this only
when recording is on.

Otherwise, this patch looks good.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]