This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH c++ 06/12] gdbserver arm: Add casts
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Tue, 03 Nov 2015 16:15:31 +0000
- Subject: Re: [PATCH c++ 06/12] gdbserver arm: Add casts
- Authentication-results: sourceware.org; auth=none
- References: <1446560804-18858-1-git-send-email-simon dot marchi at ericsson dot com> <1446560804-18858-6-git-send-email-simon dot marchi at ericsson dot com>
On 11/03/2015 02:26 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> Trivial casts for C++.
>
> Fixes things like
>
> In file included from /home/simark/src/binutils-gdb/gdb/gdbserver/../common/common-defs.h:39:0,
> from /home/simark/src/binutils-gdb/gdb/gdbserver/server.h:22,
> from /home/simark/src/binutils-gdb/gdb/gdbserver/linux-arm-low.c:19:
> /home/simark/src/binutils-gdb/gdb/gdbserver/linux-arm-low.c: In function âint arm_get_hwcap(long unsigned int*)â:
> /home/simark/src/binutils-gdb/gdb/gdbserver/../../include/libiberty.h:711:38: error: invalid conversion from âvoid*â to âunsigned char*â [-fpermissive]
> # define alloca(x) __builtin_alloca(x)
> ^
> /home/simark/src/binutils-gdb/gdb/gdbserver/linux-arm-low.c:807:25: note: in expansion of macro âallocaâ
> unsigned char *data = alloca (8);
> ^
>
> gdb/gdbserver/ChangeLog:
>
> * linux-aarch32-low.c (arm_fill_gregset): Add cast.
> (arm_store_gregset): Likewise.
> * linux-arm-low.c (arm_get_hwcap): Likewise.
> (arm_read_description): Likewise.
<rubberstamp>OK</rubberstamp>
Thanks,
Pedro Alves