This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/10] Fix breakpoint size when stepping over a permanent breakpoint in GDBServer.
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 03 Nov 2015 16:21:54 +0000
- Subject: Re: [PATCH 01/10] Fix breakpoint size when stepping over a permanent breakpoint in GDBServer.
- Authentication-results: sourceware.org; auth=none
- References: <1446138583-13268-1-git-send-email-antoine dot tremblay at ericsson dot com> <1446138583-13268-2-git-send-email-antoine dot tremblay at ericsson dot com>
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> static int
> -arm_breakpoint_at (CORE_ADDR where)
> +arm_is_thumb_mode (void)
> {
Please add comments to arm_is_thumb_mode.
> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
> index 769c876..f0fb9d7 100644
> --- a/gdb/gdbserver/target.h
> +++ b/gdb/gdbserver/target.h
> @@ -451,6 +451,12 @@ struct target_ops
> specific meaning like the Z0 kind parameter.
> SIZE is set to the software breakpoint's length in memory. */
> const gdb_byte *(*sw_breakpoint_from_kind) (int kind, int *size);
> +
> + /* Return the breakpoint kind for this target based on the current state
Maybe "current machine state" or "current processor state" is better
than "current state"?
> + (e.g. the current instruction mode on ARM) and the PC. The PCPTR is
Two spaces before "The PCPTR".
> + adjusted to the real memory location in case a flag (e.g., the Thumb
> + bit on ARM) was present in the PC. */
"is present in the PC." ?
Otherwise, looks good to me.
--
Yao (éå)