This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 07/10] Share some ARM target dependant code from GDB with GDBServer.

From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Thu, 26 Nov 2015 08:56:45 -0500
Subject: Re: [PATCH v3 07/10] Share some ARM target dependant code from GDB with GDBServer.
Authentication-results: sourceware.org; auth=none
References: <1448287968-12907-1-git-send-email-antoine dot tremblay at ericsson dot com> <1448287968-12907-8-git-send-email-antoine dot tremblay at ericsson dot com> <864mg9xcyo dot fsf at gmail dot com>



On 11/26/2015 05:38 AM, Yao Qi wrote:

Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

+/* See arm.h.  */
+
+int
+condition_true (unsigned long cond, unsigned long status_reg)


We need "arm_" prefix for this function.  Otherwise, patch is OK.


Ok in fact I guess I should add this prefix to bitcount too.

References:
- [PATCH v3 0/10] Support software single step and conditional breakpoints on ARM in GDBServer.
  - From: Antoine Tremblay
- [PATCH v3 07/10] Share some ARM target dependant code from GDB with GDBServer.
  - From: Antoine Tremblay
- Re: [PATCH v3 07/10] Share some ARM target dependant code from GDB with GDBServer.
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]