This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Ruslan Kabatsayev <b7 dot 10110111 at gmail dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 03 Dec 2015 11:27:02 +0000
- Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64
- Authentication-results: sourceware.org; auth=none
- References: <564F998D dot 5080406 at gmail dot com> <86mvttt7be dot fsf at gmail dot com> <CAHEcG95HeiLdhXFP0Zy8nz=dE9divExtau+OUg=NXo+Sb_zHfg at mail dot gmail dot com>
Ruslan Kabatsayev <b7.10110111@gmail.com> writes:
> I did a `make check` for unpatched gdb-7.10 and patched with my
> changes. Here's the unpatched result:
Thanks for running the test. Could you test your patch against GDB git
mainline please? The patch will be applied to mainline, so we need to
test it against mainline.
>
> # of expected passes 32377
> # of unexpected failures 85
> # of unexpected successes 2
> # of expected failures 72
> # of unknown successes 2
> # of known failures 62
> # of untested testcases 36
> # of unsupported tests 201
>
> And here's after my patch:
>
> # of expected passes 32378
> # of unexpected failures 85
> # of unexpected successes 2
> # of expected failures 71
> # of unknown successes 2
> # of known failures 62
> # of untested testcases 36
> # of unsupported tests 201
>
> I.e. one "expected failure" less and one "expected pass" more. I'm not
> sure how to interpret this result.
>
This may happen from time to time, especially in some gdb.threads tests.
>>> gdb/ChangeLog:
>>>
>>> * configure.host: Fix detection of x86_64 host when setting
>>> floatformats
>>
>> This line is too long, the max is 74. Sentence should be ended with ".".
>
> Should I resend the whole original mail with this fixed?
Please post the changelog entry only for the reference.
If there is no regression in the GDB mainline tests, and no objections
from other people in 3 days, your patch can go in.
Do you have write access to git repository and FSF copyright assignment?
If you don't have them, I can commit it for you as a tiny patch.
However, if you want to contribute more patches, you need an FSF
copyright assignment, and git write access, so that you can push by yourself.
--
Yao (éå)