Re: [PATCH v6 4/7] Share regcache function regcache_raw_read_unsigned.

[Antoine Tremblay <antoine dot tremblay at ericsson dot com>]

On 12/07/2015 09:40 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
> > gdb/ChangeLog:
> > 	* Makefile.in: Add common-regcache.c/.o.
>
> Need to describe what do we change in Makefile.in, like
>
>   	* Makefile.in (SFILES): Append common/common-regcache.c.
>          (COMMON_OBS): Append common/common-regcache.o.
>          (common-regcache.o): New rule.

OK, done.

> > 	* common/common-regcache.h (register_status) New enum.
> > 	(regcache_raw_read_unsigned): New declaration.
> > 	* common/common-regcache.c: New file.
> > 	* regcache.h (enum register_status): Move to common-regcache.h.
> > 	(regcache_raw_read_unsigned): Likewise.
> > 	(regcache_raw_get_unsigned): Likewise.
> >
> > gdb/gdbserver/ChangeLog:
> >
> > 	* Makefile.in: Add common-regcache.c/.o.
>
> Likewise.
>
> > 	* regcache.c (init_register_cache): Initialize cache to
> > 	REG_UNAVAILABLE.
> > 	(regcache_raw_read_unsigned): New function.
> > 	* regcache.h (REG_UNAVAILABLE, REG_VALID): Replaced by shared
> > 	register_status enum.
>
> Patch is good to me, otherwise.