This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix regression revealed by corethreads.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 10 Dec 2015 19:34:22 +0000
- Subject: Re: [PATCH] Fix regression revealed by corethreads.exp
- Authentication-results: sourceware.org; auth=none
- References: <1449774866-18369-1-git-send-email-antoine dot tremblay at ericsson dot com>
On 12/10/2015 07:14 PM, Antoine Tremblay wrote:
> This patch fixes a regression introduced by:
> https://sourceware.org/ml/gdb-patches/2015-12/msg00192.html
>
> We can't use thread_from_lwp with core files. As mentioned in a comment,
> td_ta_map_lwp2thr uses ps_get_thread_area, but we can't use that
> currently on core targets, as it uses ptrace directly.
>
> Use directly record_thread instead.
>
> This fixes :
> PASS -> FAIL: gdb.threads/corethreads.exp: thread0 found
> PASS -> FAIL: gdb.threads/corethreads.exp: thread1 found
>
> gdb/ChangeLog:
>
> * linux-thread-db.c (find_new_threads_callback): Use record_thread.
OK.
Thanks,
Pedro Alves