This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v7.1] Support software single step on ARM in GDBServer.

From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Fri, 11 Dec 2015 08:36:51 -0500
Subject: Re: [PATCH v7.1] Support software single step on ARM in GDBServer.
Authentication-results: sourceware.org; auth=none
References: <1449583641-18156-7-git-send-email-antoine dot tremblay at ericsson dot com> <1449691701-11845-1-git-send-email-antoine dot tremblay at ericsson dot com> <867fklqflh dot fsf at gmail dot com>



On 12/11/2015 08:28 AM, Yao Qi wrote:

Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

	* linux-aarch32-low.c (arm_abi_breakpoint): Remove macro.  Moved
         to linux-aarch32-low.c.
         (arm_eabi_breakpoint, arm_breakpoint): Likewise.
         (arm_breakpoint_len, thumb_breakpoint): Likewise.
         (thumb_breakpoint_len, thumb2_breakpoint): Likewise.
         (thumb2_breakpoint_len): Likewise.


I don't see how are they used outside of linux-aarch32-low.c, so why do
you move them out to linux-aarch32-low.h?


That's true, I guess I was used to breakpoint functions in linux-arm-low.c.

Fixing this now.

Thanks,
Antoine

Follow-Ups:
- Re: [PATCH v7.1] Support software single step on ARM in GDBServer.
  - From: Antoine Tremblay

References:
- [PATCH v7 6/8] Support software single step on ARM in GDBServer.
  - From: Antoine Tremblay
- [PATCH v7.1] Support software single step on ARM in GDBServer.
  - From: Antoine Tremblay
- Re: [PATCH v7.1] Support software single step on ARM in GDBServer.
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]