This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Date: Fri, 18 Dec 2015 12:50:03 -0700
- Subject: [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp
- Authentication-results: sourceware.org; auth=none
- References: <56745D29 dot 504 at codesourcery dot com>
This patch fixes a think-o in gdb.base/paginate-bg-execution.exp --
there are two calls to gdb_test with only a single argument. Looking at
the definition of this proc in lib/gdb.exp, the second argument (the
output pattern) is not supposed to be optional. For whatever reason, I
was only seeing failures on remote Windows host testing, but it must
have been an accident that it appeared to be working elsewhere.
I copied the breakpoint output pattern used elsewhere in the testsuite,
and confirmed this passes now. OK to commit?
-Sandra
2015-12-18 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* gdb.base/paginate-bg-execution.exp
(test_bg_execution_pagination_return): Add missing pattern argument
to gdb_test.
(test_bg_execution_pagination_cancel): Likewise.
diff --git a/gdb/testsuite/gdb.base/paginate-bg-execution.exp b/gdb/testsuite/gdb.base/paginate-bg-execution.exp
index f2a4d73..12d5250 100644
--- a/gdb/testsuite/gdb.base/paginate-bg-execution.exp
+++ b/gdb/testsuite/gdb.base/paginate-bg-execution.exp
@@ -37,7 +37,7 @@ proc test_bg_execution_pagination_return {} {
return 0
}
- gdb_test "b after_sleep"
+ gdb_test "b after_sleep" "Breakpoint .* at .*"
gdb_test_no_output "set height 2"
@@ -80,7 +80,7 @@ proc test_bg_execution_pagination_cancel { how } {
return 0
}
- gdb_test "b after_sleep"
+ gdb_test "b after_sleep" "Breakpoint .* at .*"
gdb_test_no_output "set height 2"