This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Joel, I hope this time it's fine. I'm also adding it in attachment just in case. Best regards, Thomas diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp index 0d17ecb..cc055f6 100644 --- a/gdb/testsuite/lib/mi-support.exp +++ b/gdb/testsuite/lib/mi-support.exp @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} { # to better handle RUN. send_gdb "jump *$start\n" warning "Using CLI jump command, expect run-to-main FAIL" + gdb_expect { + -re "${run_match}&\"jump \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} + } return 0 } > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Joel Brobecker > Sent: Saturday, December 19, 2015 2:23 AM > To: Thomas Preud'homme > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH, ping1] Add missing expect for running a program > with CLI jump > > > > 2015-10-15 Thomas Preud'homme > <thomas.preudhomme@arm.com> > > > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the > CLI > > > jump > > > case. > > I think the patch is good, but your mailer did some line folding. > Can you resend? > > Thanks! > > > > > > > > > > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi- > > > support.exp > > > index 0d17ecb..cc055f6 100644 > > > --- a/gdb/testsuite/lib/mi-support.exp > > > +++ b/gdb/testsuite/lib/mi-support.exp > > > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command > args} { > > > # to better handle RUN. > > > send_gdb "jump *$start\n" > > > warning "Using CLI jump command, expect run-to-main FAIL" > > > + gdb_expect { > > > + -re "${run_match}&\"jump > > > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa- > > > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread- > > > id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {} > > > + } > > > return 0 > > > } > > > > > > > > > With this patch applied, testsuite results become much more stable. > > > > > > Is this ok for the master branch? > > > > > > Best regards, > > > > > > Thomas > > > > > > > -- > Joel
Attachment:
gdb-runto-expect.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |