This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 05/11] [PR gdb/14441] gdb: demangle: implement demangling for rvalue reference typenames
- From: Pedro Alves <palves at redhat dot com>
- To: Artemiy Volkov <artemiyv at acm dot org>, gdb-patches at sourceware dot org
- Date: Wed, 30 Dec 2015 19:17:00 +0000
- Subject: Re: [PATCH 05/11] [PR gdb/14441] gdb: demangle: implement demangling for rvalue reference typenames
- Authentication-results: sourceware.org; auth=none
- References: <1450661481-31178-1-git-send-email-artemiyv at acm dot org> <1450661481-31178-6-git-send-email-artemiyv at acm dot org>
Hi Artemiy,
Thanks much for working on this. Just a quick note below.
On 12/21/2015 01:31 AM, Artemiy Volkov wrote:
> libiberty/ChangeLog:
>
> 2015-12-20 Artemiy Volkov <artemiyv@acm.org>
>
> * cplus-dem.c (enum type_kind_t): Add tk_rvalue_reference
> constant.
> (demangle_template_value_parm): Handle tk_rvalue_reference
> type kind.
> (do_type): Support 'O' type id (rvalue references).
It'd be nice to have a few tests in libiberty/testsuite/ to cover
this.
Note that libiberty is maintained by gcc. You need to send this
to the gcc-patches list. Once it is approved upstream, we can
merge it.
Thanks,
Pedro Alves