This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Per-inferior/Inferior-qualified thread IDs
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 05 Jan 2016 10:01:40 +0000
- Subject: Re: [PATCH v2] Per-inferior/Inferior-qualified thread IDs
- Authentication-results: sourceware.org; auth=none
- References: <1451414343-21305-1-git-send-email-palves at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
Hi, Pedro,
It is a good direction to go but can we make this patch into smaller
pieces?
> -/* *PP is a string denoting a number. Get the number of the. Advance
> - *PP after the string and any trailing whitespace.
> +/* *PP is a string denoting a number. Get the number. Advance PP
> + *after the string and any trailing whitespace.
Should be "*PP".
> +
> +# Remove the second inferior and confirm that GDB goes back to showing
> +# single-number thread IDs.
> +with_test_prefix "back to one inferior" {
> + gdb_test "kill inferior 2" "" "kill inferior 2" "Kill the program being debugged.*" "y"
> + gdb_test "thread 1.1" "Switching to thread 1\.1 .*"
> + gdb_test "remove-inferior 2" ".*" "remove inferior 2"
> +
> + # "info threads" while there's only inferior 1 should show
> + # single-number thread IDs.
> + info_threads "" "1 2 3"
> +
> + gdb_test "thread" "Current thread is 1 .*"
> +}
> +
> +# Add another inferior and remove inferior 1. Since even though
> +# there's a single inferior, it's number is not 1, GDB should show
s/it's/its/
--
Yao (éå)