Re: [PATCH v8 5/7] Support software single step on ARM in GDBServer

[Antoine Tremblay <antoine dot tremblay at ericsson dot com>]

On 01/06/2016 09:42 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
> Hi Antoine,
>
> > +/* Find the next possible PCs for thumb mode.  */
> > +VEC (CORE_ADDR) *thumb_get_next_pcs_raw (struct arm_get_next_pcs *self,
> > +					 CORE_ADDR pc);
> > +
> > +/* Find the next possible PCs for arm mode.  */
> > +VEC (CORE_ADDR) *arm_get_next_pcs_raw (struct arm_get_next_pcs *self,
> > +				       CORE_ADDR pc);
> > +
> > +#endif /* ARM_GET_NEXT_PCS_H */
>
> Is there any reason to make them extern?  I have a patch below to make
> them static.  What do you think?

No indeed they should be static. Sounds like a relic of a past 
implementation.

Thanks,
Antoine