This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH V3 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
- From: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: "brobecker at adacore dot com" <brobecker at adacore dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 13 Jan 2016 16:12:04 +0000
- Subject: RE: [PATCH V3 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
- Authentication-results: sourceware.org; auth=none
- References: <1452688799-15633-1-git-send-email-walfred dot tedeschi at intel dot com> <1452688799-15633-3-git-send-email-walfred dot tedeschi at intel dot com> <83lh7tihpw dot fsf at gnu dot org>
Eli,
I will add those fixes. Thanks for your review!
Best regards,
-Fred
-----Original Message-----
From: Eli Zaretskii [mailto:eliz@gnu.org]
Sent: Wednesday, January 13, 2016 5:10 PM
To: Tedeschi, Walfred
Cc: brobecker@adacore.com; gdb-patches@sourceware.org
Subject: Re: [PATCH V3 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Cc: gdb-patches@sourceware.org, Walfred Tedeschi
> <walfred.tedeschi@intel.com>
> Date: Wed, 13 Jan 2016 13:39:59 +0100
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,10 @@
>
> *** Changes since GDB 7.10
>
> +* show mpx-bnd-init-on-return
> + set mpx-bnd-init-on-return on i386 and amd64
> + Support for set bound registers to INIT state when using the command return.
Please quote "return" in the last sentence.
> +While the using the @command{return} bounds can propagate through
^^^
This "the" should be deleted. Also, @command is for external commands, not GDB commands.
> +execution causing a boundary violation.
Hmm... "propagate through execution" is not really clear. How about simplifying this, like below?
When you use the @code{return} command, the bound registers might
cause boundary violations because they were not updated for the
early return from the function.
> +The behaviour of initializing bounds when using @command{return} can
> +be controlled and vizualized via the following commands:
I think we should explain how initializing these registers comes into play. Like this, for example:
To countermand that, @value{GDBN} can force initialization of the
bound registers when it performs the @code{return} command. This is
controlled by the following option:
The documentation parts are OK with these fixes.
Thanks.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928