This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Star wildcard ranges (e.g., "info thread 2.*")


> Date: Thu, 14 Jan 2016 11:13:47 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> >> +* In commands that accept thread IDs lists, you can now refer to all
> > 
> > "thread ID lists", only one word in plural.  Or maybe even better:
> > "lists of thread IDs".
> 
> Hmm, going further, I think that "list" should be singular too:
> 
>  In commands that accept a thread ID list, you can now refer to all
>  In commands that accept a list of thread IDs, you can now refer to all
> 
> I prefer the former because "thread ID list" is a defined term in
> the manual.

I won't bykeshed over it, but just so you know: use of double "status
constructus" in English is not a good style, because it is ambiguous
-- is "thread ID list" an ID list of a thread or a list of thread
IDs?  The simple "list of thread IDs" disambiguates that.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index fbc76fa..a08a196 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -2916,17 +2916,17 @@ argument.  A list element can be:
> 
>  @enumerate
>  @item
> -a thread ID as shown in the first field of the @samp{info threads}
> +A thread ID as shown in the first field of the @samp{info threads}
>  display, with or without an inferior qualifier.  E.g., @samp{2.1} or
>  @samp{1}.
> 
>  @item
> -a range of thread numbers, again with or without an inferior
> +A range of thread numbers, again with or without an inferior
>  qualifier, as in @var{inf}.@var{thr1}-@var{thr2} or
>  @var{thr1}-@var{thr2}.  E.g., @samp{1.2-4} or @samp{2-4}.
> 
>  @item
> -all threads of an inferior, specified with a star wildcard, with or
> +All threads of an inferior, specified with a star wildcard, with or
>  without an inferior qualifier, as in @var{inf}.@code{*} (e.g.,
>  @samp{1.*}) or @code{*}.  The former refers to all threads of the
>  given inferior, and the latter form without an inferior qualifier

Thanks, this is OK.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]