This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: DJGPP specific fix for struct serial_ops in ser-go32.c
- From: Pedro Alves <palves at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Cc: Juan Manuel Guerrero <juan dot guerrero at gmx dot de>
- Date: Fri, 15 Jan 2016 20:39:55 +0000
- Subject: Re: DJGPP specific fix for struct serial_ops in ser-go32.c
- Authentication-results: sourceware.org; auth=none
- References: <5693F8E1 dot 4040602 at gmx dot de> <83twmffdne dot fsf at gnu dot org>
On 01/15/2016 08:30 AM, Eli Zaretskii wrote:
>> Date: Mon, 11 Jan 2016 19:48:01 +0100
>> From: Juan Manuel Guerrero <juan.guerrero@gmx.de>
>>
>> This is a fix for the DJGPP port of gdb.
>> I do not know when this has changed but the numbers of arguments passed to
>> setparity of struct serial_ops no longer match the number of arguments of
>> dos_noop. The patch below fixes the issue providing a new dummy function.
>
> Any objections, anyone? The patch looks obviously correct to me, so
> I'd like to commit it.
I think the intention is to install ser_base_setparity, which is itself
a dummy function, when the feature is not supported:
ser-mingw.c: ser_base_setparity,
ser-mingw.c: ser_base_setparity,
ser-pipe.c: ser_base_setparity,
ser-tcp.c: ser_base_setparity,
Thanks,
Pedro Alves