This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gnu_vector.exp: Respect `should_kfail' for PR8549
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Wed, 20 Jan 2016 09:31:58 +0000
- Subject: Re: [PATCH] gnu_vector.exp: Respect `should_kfail' for PR8549
- Authentication-results: sourceware.org; auth=none
- References: <m3h9i9sf64 dot fsf at oc1027705133 dot ibm dot com> <864me9tqxc dot fsf at gmail dot com> <m3d1sxs8zo dot fsf at oc1027705133 dot ibm dot com>
Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
> Doing the KFAIL based on the target triplet would miss the point of this
> test on s390x, because on the same target "s390x-ibm-linux-gnu" the test
> shall succeed if the CPU has vector registers and the vector ABI is
> used, but is known to fail if a non-vector ABI is used. (Note that the
> main reason for enhancing the gnu_vector test case was to verify GDB's
> correct treatment of the s390x vector ABI.)
Could you add some comments in the test case about what you said above?
>
> But testing against some expected return value in this case is certainly
> wrong. I suggest to change my patch like follows. WDYT?
That is fine with me.
--
Yao (éå)