This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] gnu_vector.exp: Respect `should_kfail' for PR8549
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org, Yao Qi <yao dot qi at arm dot com>
- Date: Wed, 20 Jan 2016 19:44:21 +0100
- Subject: Re: [PATCH v2] gnu_vector.exp: Respect `should_kfail' for PR8549
- Authentication-results: sourceware.org; auth=none
- References: <m337tssc8t dot fsf at oc1027705133 dot ibm dot com> <86k2n4s6n6 dot fsf at gmail dot com>
On Wed, Jan 20 2016, Yao Qi wrote:
> Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
>
> Hi Andreas,
> Patch is OK to me,
>
>> -gdb_test "p res" "\\{4, 2, 7, 6\\}.*" "verify vector return value"
>> +set test "verify vector return value"
>> +gdb_test_multiple "p res" $test {
>> + -re ".*= \\{4, 2, 7, 6\\}\r\n.*$gdb_prompt $" {
>> + pass $test
>> + }
>> + -re ".*= \\{.*\\}\r\n.*$gdb_prompt $" {
>> + if { $should_kfail } {
>> + # GDB had not actually set the return value, likely due to
>> + # PR8549. So accept any return value and emit a KFAIL.
>
> Nit, we need a space between "PR" and "8549".
OK, I've committed the patch with that change. Thanks!
--
Andreas