This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] rx: Treat scalars larger than 8 bytes as aggregates in rx_push_dummy_call
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 26 Jan 2016 16:39:38 +0400
- Subject: Re: [PATCH] rx: Treat scalars larger than 8 bytes as aggregates in rx_push_dummy_call
- Authentication-results: sourceware.org; auth=none
- References: <20160123161811 dot 1c92dd3d at pinnacle dot lan>
Hi Kevin,
> gdb/ChangeLog:
>
> * rx-tdep.c (rx_push_dummy_call): Treat scalars larger than 8
> bytes as aggregates.
I'll trust you on RX matters, and the contents of the message
seems to indicate that you would have tested the change using
our testsuite, so...
OK with me! :-)
> ---
> gdb/rx-tdep.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/rx-tdep.c b/gdb/rx-tdep.c
> index 2732608..904aebd 100644
> --- a/gdb/rx-tdep.c
> +++ b/gdb/rx-tdep.c
> @@ -813,7 +813,8 @@ rx_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
> struct_addr);
> }
> else if (TYPE_CODE (arg_type) != TYPE_CODE_STRUCT
> - && TYPE_CODE (arg_type) != TYPE_CODE_UNION)
> + && TYPE_CODE (arg_type) != TYPE_CODE_UNION
> + && arg_size <= 8)
> {
> /* Argument is a scalar. */
> if (arg_size == 8)
--
Joel