This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/8] gdb.trace: Fix write_inferior_data_ptr on 32-bit big-endian machines.


On 26/01/16 14:32, Ulrich Weigand wrote:
Marcin KoÃâcielnicki wrote:

	* tracepoint.c (write_inferior_data_ptr): Cast to uintptr_t, so that
	it works properly on big-endian machines where sizeof (CORE_ADDR)
	!= sizeof (void *).

This is the same problem that was detected on PowerPC here:
https://sourceware.org/ml/gdb-patches/2015-03/msg00996.html

Unfortunately that patch, while approved, never got committed.  It still
seems to be the better solution, since now there's two basically identical
routines write_inferior_data_ptr and write_inferior_data_pointer for no
particular reason ...

Bye,
Ulrich



I'll remove the duplicated function.

Is there a chance of getting this patchset commited? I see I duplicated a good chunk of work done there, it's a matter of time before someone likewise stumbles upon other already-fixed issues...

Marcin KoÅcielnicki


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]