This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[pushed][PATCH V5 3/5] Add bound related fields to the siginfo structure


Pushed with changes

-----Original Message-----
From: Pedro Alves [mailto:palves@redhat.com] 
Sent: Thursday, January 28, 2016 1:23 PM
To: Tedeschi, Walfred; eliz@gnu.org; brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V5 3/5] Add bound related fields to the siginfo structure

On 01/22/2016 02:54 PM, Walfred Tedeschi wrote:
> Both Linux and glibc have introduced bound related fields in the 
> segmentation fault fields of the siginfo_t type. Ass the new fields to our x86's siginfo_t type too.

"Add the " ...

> @@ -342,6 +344,18 @@ linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch,
>    /* _sigfault */
>    type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
>    append_composite_type_field (type, "si_addr", void_ptr_type);
> +
> +  /* additional bound fields for _sigfault in case they are added.  
> + */

"Additional", uppercase.

"in case they were requested.".

> +  if ((extra_fields & LINUX_SIGINFO_FIELD_ADDR_BND) != 0)
> +    {

OK with those changes.

Thanks,
Pedro Alves

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]