This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: branching for GDB 7.11 soon? (possibly Wed)
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, Joel Brobecker <brobecker at adacore dot com>, "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Mon, 08 Feb 2016 20:06:40 +0000
- Subject: Re: RFC: branching for GDB 7.11 soon? (possibly Wed)
- Authentication-results: sourceware.org; auth=none
- References: <20160201030638 dot GG4008 at adacore dot com> <20160207081230 dot GA20874 at adacore dot com> <56B8EC41 dot 7080004 at redhat dot com>
On 02/08/2016 07:28 PM, Keith Seitz wrote:
> I looked at this over the weekend and updated the bz. It seems pretty
> trivial, and the patch is very safe to use.
>
> In short, update_breakpoints_after_exec is charged with deleting any
> breakpoint with no location. momentary_breakpoint types were implemented
> to rely on this behavior. So b->location can be NULL, contrary to what I
> previously assumed.
>
> Simply handling NULL in location_empty_p fixes this.
>
> Writing a test for this now.
Thanks Keith. Having the testsuite cover this would be great.
BTW, calling both b->location and the b->loc things "locations"
is ambiguous and confusing, IMO. How about we start calling
the new b->location, the "location spec" ?
Thanks,
Pedro Alves