This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] gdb.trace: Use g packet order in tfile_fetch_registers.
- From: Pedro Alves <palves at redhat dot com>
- To: Marcin KoÅcielnicki <koriakin at 0x04 dot net>, gdb-patches at sourceware dot org
- Date: Wed, 10 Feb 2016 13:20:36 +0000
- Subject: Re: [PATCH 3/4] gdb.trace: Use g packet order in tfile_fetch_registers.
- Authentication-results: sourceware.org; auth=none
- References: <1454773157-31569-1-git-send-email-koriakin at 0x04 dot net> <1454773157-31569-4-git-send-email-koriakin at 0x04 dot net>
On 02/06/2016 03:39 PM, Marcin KoÅcielnicki wrote:
> tfile_fetch_registers currently wrongly fetches registers using
> gdb order instead of g packet order. On x86_64 with AVX, this causes
> problems with ymm*h and orig_rax registers: gdb has ymm*h first, while
> g packet has orig_rax first.
>
> gdb/ChangeLog:
>
> * tracefile-tfile.c (tfile_fetch_registers): Use g packet order
> instead of gdb order.
OK.
The docs already explicitly say that we use g packet order, though the
bit about GDB register order seems odd:
@table @code
@item R @var{bytes}
Register block. The number and ordering of bytes matches that of a
^^^^^^^^ ^^^^^^^
@code{g} packet in the remote protocol. Note that these are the
^^^^^^^^^^^^^^^
actual bytes, in target order and @value{GDBN} register order, not a
^^^^^^^^^^^^^^^^^^^^^^^^^^^
????
hexadecimal encoding.
I can't make sense of that. I think we should
s/and @value{GDBN} register order,// .
WDYT?
Thanks,
Pedro Alves