This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 11 Feb 2016 10:54:25 +0000
- Subject: Re: [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn
- Authentication-results: sourceware.org; auth=none
- References: <1455128356-4483-1-git-send-email-simon dot marchi at ericsson dot com>
Simon Marchi <simon.marchi@ericsson.com> writes:
> This function is never used, since it is superseded by
> arm_linux_displaced_step_copy_insn.
>
> gdb/ChangeLog:
>
> * arm-tdep.c (arm_displaced_step_copy_insn): Remove.
> * arm-tdep.h (arm_displaced_step_copy_insn): Remove.
arm_displaced_step_copy_insn is still referenced in the comments in
arm-linux-tdep.c,
/* Linux-specific displaced step instruction copying function. Detects when
the program has stepped into a Linux kernel helper routine (which must be
handled as a special case), falling back to arm_displaced_step_copy_insn()
if it hasn't. */
Can you remove it from the comments as well? These comments can be
simplified further like
/* Implement the "displaced_step_copy_insn" gdbarch method. */
OK with the change like this.
--
Yao (éå)