This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn


Simon Marchi <simon.marchi@ericsson.com> writes:

> This function is never used, since it is superseded by
> arm_linux_displaced_step_copy_insn.
>
> gdb/ChangeLog:
>
> 	* arm-tdep.c (arm_displaced_step_copy_insn): Remove.
> 	* arm-tdep.h (arm_displaced_step_copy_insn): Remove.

arm_displaced_step_copy_insn is still referenced in the comments in
arm-linux-tdep.c,

/* Linux-specific displaced step instruction copying function.  Detects when
   the program has stepped into a Linux kernel helper routine (which must be
   handled as a special case), falling back to arm_displaced_step_copy_insn()
   if it hasn't.  */

Can you remove it from the comments as well?  These comments can be
simplified further like

/* Implement the "displaced_step_copy_insn" gdbarch method.  */

OK with the change like this.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]