This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 18/02/16 16:58, Ulrich Weigand wrote:
Marcin Kościelnicki wrote:On 18/02/16 16:40, Ulrich Weigand wrote:I don't think you actually need this include, do you? Otherwise, this patch is OK. Bye, UlrichI do, the default_guess_tracepoint_registers function is declared there, and gdbarch.c uses it.Ah, right. You should probably move the prototype to arch-utils.h (and then the implementation to arch-utils.c) to go with the other default_ functions.
Alright, I'll do that.
Since gdbarch.h is included everywhere, we try to avoid having it include other headers as far as possible.
FWIW, the header include I added only ends up in gdbarch.c, .h is unaffected.
Bye, Ulrich
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |