This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] gdb/s390: Fill guess_tracepoint_registers hook.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Cc: arnez at linux dot vnet dot ibm dot com, gdb-patches at sourceware dot org, koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Date: Thu, 18 Feb 2016 17:03:33 +0100 (CET)
- Subject: Re: [PATCH 2/2] gdb/s390: Fill guess_tracepoint_registers hook.
- Authentication-results: sourceware.org; auth=none
Marcin KoÅ?cielnicki wrote:
> * s390-linux-tdep.c (s390_guess_tracepoint_registers): New function.
> (s390_gdbarch_init): Fill guess_tracepoint_registers hook.
I think it would be better to also initialize PSWM to a valid value,
in particular since on 64-bit the addressing mode bits are actually
in the PSWM instead of the PSWA (and at least in principle even GDB
itself occasionally may check the addressing mode bits).
A default valid value for PSWM would be
0x070d0000UL in ESA mode
0x0705000180000000UL in zArchitecture mode (64-bit addressing mode)
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com