This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gdb.trace: Fix unavailable.exp if last register happens to be PC.

From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 22 Feb 2016 18:57:48 +0100
Subject: Re: [PATCH] gdb.trace: Fix unavailable.exp if last register happens to be PC.
Authentication-results: sourceware.org; auth=none
References: <1456126517-23020-1-git-send-email-koriakin at 0x04 dot net> <86io1gd4tg dot fsf at gmail dot com>

On 22/02/16 18:37, Yao Qi wrote:

Marcin KoÅcielnicki <koriakin@0x04.net> writes:

unavailable.exp executes "info registers", expecting to find at least
two instances of "<unavailable>".  However, it uses
"<unavailable>.*<unavailable>" as the pattern, which doesn't match
when the last register happens to be available (eg. PC).  Change it
to ".*<unavailable>.*<unavailable>.*" instead.

Noticed on s390, no regression on x86_64.

gdb/testsuite/ChangeLog:

	* gdb.trace/unavailable.exp (gdb_unavailable_registers_test_1): Fix
	info registers pattern.


Patch looks good to me.


Thanks, pushed.

References:
- [PATCH] gdb.trace: Fix unavailable.exp if last register happens to be PC.
  - From: Marcin KoÅcielnicki
- Re: [PATCH] gdb.trace: Fix unavailable.exp if last register happens to be PC.
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]