This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/8] [GDBserver] Leave child suspended when step over parent
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 25 Feb 2016 17:11:56 +0000
- Subject: Re: [PATCH 1/8] [GDBserver] Leave child suspended when step over parent
- Authentication-results: sourceware.org; auth=none
- References: <1455892594-2294-1-git-send-email-yao dot qi at linaro dot org> <1455892594-2294-2-git-send-email-yao dot qi at linaro dot org>
LGTM.
On 02/19/2016 02:36 PM, Yao Qi wrote:
> /* If we're suspending all threads, leave this one suspended
> - too. */
> - if (stopping_threads == STOPPING_AND_SUSPENDING_THREADS)
> + too. If we're stepping over the parent, all other threads
> + have been suspended already, leave this one suspended too. */
I'd write:
too. If the fork/clone parent is stepping over a breakpoint, all
other threads have been suspended already. Leave the child
suspended too. */
Thanks,
Pedro Alves