This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 08/11] [PR gdb/14441] gdb: convert lvalue reference type check to general reference type check
- From: Artemiy Volkov <artemiyv at acm dot org>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 25 Feb 2016 21:06:50 -0800
- Subject: Re: [PATCH v2 08/11] [PR gdb/14441] gdb: convert lvalue reference type check to general reference type check
- Authentication-results: sourceware.org; auth=none
- References: <1450661481-31178-1-git-send-email-artemiyv at acm dot org> <1453229609-20159-1-git-send-email-artemiyv at acm dot org> <1453229609-20159-9-git-send-email-artemiyv at acm dot org> <56C7666D dot 9000700 at redhat dot com>
On Fri, Feb 19, 2016 at 11:01:01AM -0800, Keith Seitz wrote:
[snip]
> > 2016-01-19 Artemiy Volkov <artemiyv@acm.org>
> >
> > * gdb/aarch64-tdep.c (aarch64_type_align): Change TYPE_CODE_REF
> > check to TYPE_REFERENCE check.
> > (aarch64_extract_return_value): Likewise.
> > (aarch64_store_return_value): Likewise.
> > * gdb/amd64-tdep.c (amd64_classify): Likewise.
> [big snip]
>
> We are now encouraging/permitting developers to use the phrase "Update
> all callers." or "All callers updated." with large, mechanical changes
> like this.
>
This phrase doesn't fit here, does it? There's no function signature
changes, thus no callers really get updated. Maybe I should leave the
"likewise"s as they were or rephrase it in some other way?
Thanks,
Artemiy