This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 08/11] [PR gdb/14441] gdb: convert lvalue reference type check to general reference type check


On Fri, Feb 19, 2016 at 11:01:01AM -0800, Keith Seitz wrote:

[snip]

> > 2016-01-19  Artemiy Volkov  <artemiyv@acm.org>
> > 
> >         * gdb/aarch64-tdep.c (aarch64_type_align): Change TYPE_CODE_REF
> >         check to TYPE_REFERENCE check.
> >         (aarch64_extract_return_value): Likewise.
> >         (aarch64_store_return_value): Likewise.
> >         * gdb/amd64-tdep.c (amd64_classify): Likewise.
> [big snip]
> 
> We are now encouraging/permitting developers to use the phrase "Update
> all callers." or "All callers updated." with large, mechanical changes
> like this.
> 

This phrase doesn't fit here, does it? There's no function signature
changes, thus no callers really get updated. Maybe I should leave the
"likewise"s as they were or rephrase it in some other way?

Thanks,
Artemiy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]