This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V4 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Walfred Tedeschi <walfred dot tedeschi at intel dot com>
- Cc: palves at redhat dot com, brobecker at adacore dot com, gdb-patches at sourceware dot org, walfred dot tedeschi at intel dot com
- Date: Wed, 02 Mar 2016 18:35:31 +0200
- Subject: Re: [PATCH V4 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
- Authentication-results: sourceware.org; auth=none
- References: <1456935689-1820-1-git-send-email-walfred dot tedeschi at intel dot com> <1456935689-1820-3-git-send-email-walfred dot tedeschi at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Cc: gdb-patches@sourceware.org, Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Wed, 2 Mar 2016 17:21:29 +0100
>
> +While the using the @command{return} bounds can propagate through
> +execution causing a boundary violation.
This sentence needs to be rephrased.
> +@kindex set mpx-bnd-init-on-return
> +When set to true bound registers will be set to the INIT state when
> +using the "return" command.
> +@kindex show mpx-bnd-init-on-return
> +Show the state of mpx-bnd-init-on-return.
This last sentence should explain what is shown; just referring to the
variable name doesn't do the job.
> + add_setshow_boolean_cmd ("mpx-bnd-init-on-return", no_class,
> + &mpx_bnd_init_on_return, _("\
> + Set the bnd registers to INIT state when returning from a call."), _("\
> + Show the state of the mpx-bnd-init-on-return."),
For the 'show" part, we usually use the following wording:
Show whether to set the bnd registers to INIT state when returning from a call.
Thanks.