This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/3] PR remote/19496, interrupted syscall in forking-threads-plus-bkpt
- From: Pedro Alves <palves at redhat dot com>
- To: Don Breazeal <donb at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Tue, 15 Mar 2016 12:55:36 +0000
- Subject: Re: [PATCH v2 2/3] PR remote/19496, interrupted syscall in forking-threads-plus-bkpt
- Authentication-results: sourceware.org; auth=none
- References: <1455150484-12600-1-git-send-email-donb at codesourcery dot com>
Hi Don,
On 02/11/2016 12:28 AM, Don Breazeal wrote:
> So, the bottom line is that I haven't changed the fix for the interrupted
> system calls, because I can't find anything that works as well as the
> original fix. Perhaps this test puts enough stress on the kernel that the
> kernel bugs mentioned above are exposed.
Many thanks for the thorough investigation. Let's take your
original approach then.
>
> One change I did make from the previous version was to increase the
> timeout to 90 seconds, which was necessary to get more reliable results
> on the Nios II target.
> diff --git a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp
> index ff3ca9a..6889c2b 100644
> --- a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp
> +++ b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp
> @@ -73,6 +73,9 @@ proc do_test { cond_bp_target detach_on_fork displaced } {
> global linenum
> global is_remote_target
>
> + global timeout
> + set timeout 90
> +
Use with_timeout_factor instead so that the timeout is properly restored,
and put it around the problematic test, only, instead of basically
around the whole test case. I think that'll be the "inferior 1 exited"
test?
> set saved_gdbflags $GDBFLAGS
> set GDBFLAGS [concat $GDBFLAGS " -ex \"set non-stop on\""]
> clean_restart $binfile
Thanks,
Pedro Alves