This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 07/11] [PR gdb/14441] gdb: dwarf2read: support DW_AT_rvalue_reference type
- From: Keith Seitz <keiths at redhat dot com>
- To: Artemiy Volkov <artemiyv at acm dot org>, gdb-patches at sourceware dot org
- Date: Wed, 16 Mar 2016 15:28:28 -0700
- Subject: Re: [PATCH v3 07/11] [PR gdb/14441] gdb: dwarf2read: support DW_AT_rvalue_reference type
- Authentication-results: sourceware.org; auth=none
- References: <1453229609-20159-1-git-send-email-artemiyv at acm dot org> <1457147955-21871-1-git-send-email-artemiyv at acm dot org> <1457147955-21871-8-git-send-email-artemiyv at acm dot org>
On 03/04/2016 07:19 PM, Artemiy Volkov wrote:
> Make gdb DWARF reader understand the DW_AT_rvalue_reference type tag. Handling
> of this tag is done in the existing read_tag_reference_type() function, to
> which we add a new parameter representing the kind of reference type
> (lvalue vs rvalue).
>
> gdb/ChangeLog:
>
> 2016-03-03 Artemiy Volkov <artemiyv@acm.org>
>
> * dwarf2read.c (process_die, read_type_die_1): Handle the
> DW_AT_rvalue_reference_type DIE.
^^^^^^^^^^^^^^^^^^^^^^^^^^^
> (read_tag_reference_type): Add new parameter "refcode".
DW_TAG_rvalue_reference_type?
> ---
> gdb/dwarf2read.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
Otherwise this looks good to me.
Keith