This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] gdb: xtensa: fix frame initialization when PC is invalid
- From: Pedro Alves <palves at redhat dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>, gdb-patches at sourceware dot org
- Cc: Maxim Grigoriev <maxim2405 at gmail dot com>, Woody LaRue <larue at cadence dot com>, Marc Gauthier <marc at cadence dot com>
- Date: Tue, 29 Mar 2016 20:09:30 +0100
- Subject: Re: [PATCH v2] gdb: xtensa: fix frame initialization when PC is invalid
- Authentication-results: sourceware.org; auth=none
- References: <1459275473-11718-1-git-send-email-jcmvbkbc at gmail dot com>
On 03/29/2016 07:17 PM, Max Filippov wrote:
> - op1 = read_memory_integer (pc, 1, byte_order);
> - if (XTENSA_IS_ENTRY (gdbarch, op1))
> + if (safe_read_memory_integer (pc, 1, byte_order, &op1)
> + && XTENSA_IS_ENTRY (gdbarch, op1))
> {
I'm surprised if this compiles without an "incompatible pointer type"
warning/error? safe_read_memory_integer's last parameter is
'LONGEST *', while op1 is 'char', AFAICS. So you need to change op1
to be a LONGEST to match.
Thanks,
Pedro Alves