This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>, Par Olsson <par dot olsson at windriver dot com>
- Date: Thu, 31 Mar 2016 13:45:46 -0400
- Subject: Re: [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag
- Authentication-results: sourceware.org; auth=none
- References: <1459351018-23718-1-git-send-email-simon dot marchi at ericsson dot com> <86oa9urkcm dot fsf at gmail dot com>
On 16-03-31 06:51 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> I am sending this fix on behalf of Par Olsson, as a follow-up of this
>> one:
>>
>> https://www.sourceware.org/ml/gdb-patches/2015-10/msg00196.html
>
> Hi Simon,
> The patch in the url above is to change 'enabled' field to uint32_t, so
> I guess you got the patch below from Par Olsson off list?
>
> The reason I ask this is that I find the author doesn't have the copyright
> assignment. We can take it as a tiny patch, if no one has objections.
Par indeed sent us this off-list. But as Pedro mentioned, Wind River is covered.
>
>> static int
>> +write_inferior_int8 (CORE_ADDR symaddr, int8_t val)
>> +{
>> + return write_inferior_memory (symaddr, (unsigned char *) &val, sizeof (val));
>
> This line is too long.
It's 79 characters long, no? It's the same line as the line in write_inferior_integer,
I think they are both ok.
> The patch itself is good to me.
Ok thanks, I'll push it when the corresponding test is accepted.