This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Set bp_tgt->reqstd_address and bp_tgt->placed_size in record_full_insert_breakpoint


On 04/06/2016 03:36 AM, Yao Qi wrote:
Luis Machado <lgustavo@codesourcery.com> writes:

+      CORE_ADDR addr = bp_tgt->reqstd_address;

Do we really need to get this initialized?


Yes, 'addr' is passed to gdbarch_breakpoint_from_pc below.


Ah, indeed. For a moment i thought addr was initialized within gdbarch_breakpoint_from_pc.

+      int bplen;
+
+      gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen);
+
+      bp_tgt->placed_address = addr;
+      bp_tgt->placed_size = bplen;



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]