Re: [PATCH] Improve maint print symbols,psymbols,msymbols

[Eli Zaretskii <eliz at gnu dot org>]

> From: Doug Evans <xdje42@gmail.com>
> Date: Wed, 20 Apr 2016 10:30:13 -0700
> 
> 2016-04-20  Doug Evans  <xdje42@gmail.com>
> 
> 	* NEWS: Document new syntax for "mt print symbols", "mt print psymbols"
> 	and "mt print msymbols" commands.
> 	* psymtab.c (DEV_TTY): Delete.
> 	(dump_psymtab_addrmap): Don't dump if psymtabs_addrmap is NULL.
> 	(maintenance_print_psymbols): Rewrite for new syntax:
> 	mt print psymbols [-objfile objfile] [-pc address] [outfile]
> 	mt print psymbols [-objfile objfile] [-source source] [outfile]
> 	(_initialize_psymtab): Update help text.
> 	* symmisc.c (maintenance_print_symbols): Rewrite for new syntax:
> 	mt print symbols [-pc address] [outfile]
> 	mt print symbols [-objfile objfile] [-source source] [outfile]
> 	(maintenance_print_msymbols): Rewrite for new syntax:
> 	mt print msymbols [-objfile objfile] [outfile]
> 	Only print symbols for the current progspace.
> 	(_initialize_symmisc): Update help text.
> 
> 	doc/
> 	* gdb.texinfo (Symbols): Update docs for symbol printing maintenance
> 	commands.
> 
> 	testsuite/
> 	* gdb.base/maint.exp: Update tests for maint print symbols, psymbols
> 	and msymbols.

OK for the documentation parts, except this nit:

> +If @code{-objfile @var{OBJFILE}} is specified, only dump symbols for
> +that objfile.
> +If @code{-pc @var{address}} is specified, only dump symbols for the file
> +with code at that address.  Note that @var{address} may be a symbol like
> +@code{main}.
> +If @code{-source @var{SOURCE}} is specified, only dump symbols for that
> +source file.

The arguments of @var shouldn't be in CAPS.

Thanks.