This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/8] Add self-test framework to gdb
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Tom Tromey <tom at tromey dot com>, Yao Qi <qiyaoltc at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 29 Apr 2016 16:54:24 -0400
- Subject: Re: [PATCH v2 3/8] Add self-test framework to gdb
- Authentication-results: sourceware.org; auth=none
- References: <1461789279-15996-1-git-send-email-tom at tromey dot com> <1461789279-15996-4-git-send-email-tom at tromey dot com> <86wpnido3w dot fsf at gmail dot com> <877ffgbg8h dot fsf at tromey dot com> <868tzwe8n7 dot fsf at gmail dot com> <87wpngqhcq dot fsf at tromey dot com>
On 16-04-29 04:40 PM, Tom Tromey wrote:
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 400d2b0..c99bca6 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -869,8 +869,10 @@ SFILES = ada-exp.y ada-lang.c ada-typeprint.c ada-valprint.c ada-tasks.c \
> proc-service.list progspace.c \
> prologue-value.c psymtab.c \
> regcache.c reggroups.c remote.c remote-fileio.c remote-notif.c reverse.c \
> - sentinel-frame.c \
> + selftest.c sentinel-frame.c \
> serial.c ser-base.c ser-unix.c ser-event.c skip.c \
> + selftest.c sentinel-frame.c \
> + serial.c ser-base.c ser-unix.c skip.c \
I think that some filenames/lines end up duplicated here.
May I suggest that in the future, we add each filename on its own line
in those lists? Not only does it make it easier to add files in the
middle of the list, it also makes diffs much clearer.