This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][gdb] Fix -Wparentheses warnings
- From: Pedro Alves <palves at redhat dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, gdb-patches at sourceware dot org
- Date: Mon, 2 May 2016 18:03:10 +0100
- Subject: Re: [PATCH][gdb] Fix -Wparentheses warnings
- Authentication-results: sourceware.org; auth=none
- References: <57237D3A dot 2050203 at foss dot arm dot com> <55918437-8fb0-3d99-645a-667339829bc8 at redhat dot com>
On 05/02/2016 11:57 AM, Pedro Alves wrote:
> On 04/29/2016 04:26 PM, Kyrill Tkachov wrote:
> Bah. That's written that way exactly to avoid dangling if/else
> problems.
>
> I think it'd be reasonable for gcc to not warn when the if/else
> came from a macro, as users of the macro can't possibly be confused
> in the way the warning intents to help with. I'd call it a
> gcc regression.
>
...
>> Is this ok to commit?
>
> OK.
I suspect this may be the same as PR20029:
https://sourceware.org/bugzilla/show_bug.cgi?id=20029
Could you push it to the gdb-7.11-branch branch too, please?
Thanks,
Pedro Alves