This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Fortran, typeprint: Take level of details into account when printing elements of a structure.
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Bernhard Heckel <bernhard dot heckel at intel dot com>
- Cc: qiyaoltc at gmail dot com, gdb-patches at sourceware dot org
- Date: Thu, 12 May 2016 13:06:12 +0100
- Subject: Re: [PATCH 2/4] Fortran, typeprint: Take level of details into account when printing elements of a structure.
- Authentication-results: sourceware.org; auth=none
- References: <1462889739-30359-1-git-send-email-bernhard dot heckel at intel dot com> <1462889739-30359-3-git-send-email-bernhard dot heckel at intel dot com>
Bernhard Heckel <bernhard.heckel@intel.com> writes:
> - f_type_print_base (TYPE_FIELD_TYPE (type, index), stream, show,
> - level + 4);
> - fputs_filtered (" :: ", stream);
> - fputs_filtered (TYPE_FIELD_NAME (type, index), stream);
> - f_type_print_varspec_suffix (TYPE_FIELD_TYPE (type, index),
> - stream, 0, 0, 0, 0);
> fputs_filtered ("\n", stream);
> - }
> - fprintfi_filtered (level, stream, "End Type ");
> - fputs_filtered (TYPE_TAG_NAME (type), stream);
> + for (index = 0; index < TYPE_NFIELDS (type); index++)
> + {
> + f_type_print_base (TYPE_FIELD_TYPE (type, index), stream, show - 1,
> + level + 4);
I read this patch again, and happen to see that we pass "show - 1" to
f_type_print_base instead of "show". I think the change is correct, but
it shouldn't fall in this patch, right?
--
Yao (éå)