This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 2/3] use reinsert breakpoint for vCont;s
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 12 May 2016 17:38:30 +0100
- Subject: Re: [RFC 2/3] use reinsert breakpoint for vCont;s
- Authentication-results: sourceware.org; auth=none
- References: <1462530736-25117-1-git-send-email-yao dot qi at linaro dot org> <1462530736-25117-3-git-send-email-yao dot qi at linaro dot org> <8660ukev20 dot fsf at gmail dot com> <wwokeg97l6fe dot fsf at ericsson dot com>
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> I though we would have to explicitly stop the threads, I'm curious has
> to where you moved it so that the threads are stopped ?
I moved the code deleting reinsert breakpoint to the place where
GDBserver is ready to report a stop back to GDB, because on this point,
all threads stop in all-stop mode, and the event thread stops in
no-stop mode. In non-stop mode, I delete the reinsert breakpoint of
event thread, while in all-stop mode, I delete the reinsert breakpoint
of all threads.
You are right that it is unsafe to remove reinsert breakpoint while some
threads are still running (in non-stop mode).
--
Yao (éå)