This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [GDBserver] step over shouldn't be ongoing in proceed_one_lwp
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 May 2016 10:15:43 +0100
- Subject: Re: [PATCH] [GDBserver] step over shouldn't be ongoing in proceed_one_lwp
- Authentication-results: sourceware.org; auth=none
- References: <1461917301-1959-1-git-send-email-yao dot qi at linaro dot org>
Yao Qi <qiyaoltc@gmail.com> writes:
> proceed_one_lwp is called by either unstop_all_lwps or proceed_all_lwps,
> and the step over shouldn't be ongoing, either not started or finished,
> so the "else if (lwp->bp_reinsert != 0)" looks like a dead code. This
> patch is to remove it, add an assert that "lwp->bp_reinsert == 0", and
> remove some comments in proceed_one_lwp.
The assert added by this patch can be triggered if GDBserver pauses all
lwps (due to requested memory access) when one thread is stepping over a
breakpoint, for example, we have a target-side conditional breakpoint,
continue inferior in background, and request memory access from GDB
(disassemble main).
--
Yao (éå)