This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix invalid implicit conversions from void *
- From: Andreas Schwab <schwab at suse dot de>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 19 May 2016 15:32:30 +0200
- Subject: Re: [PATCH] Fix invalid implicit conversions from void *
- Authentication-results: sourceware.org; auth=none
- References: <mvminya5hu9 dot fsf at hawking dot suse dot de> <27288423-ea78-4bd7-6eb2-68911a275690 at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> On 05/19/2016 01:54 PM, Andreas Schwab wrote:
>> Tested on ia64-suse-linux.
>
> Thanks.
>
>>
>> * ia64-libunwind-tdep.c (libunwind_descr): Add cast from void *.
>> (libunwind_frame_set_descr): Likewise.
>> (libunwind_frame_cache): Likewise.
>> (libunwind_frame_dealloc_cache): Likewise.
>> (libunwind_frame_sniffer): Likewise.
>> (libunwind_search_unwind_table): Likewise.
>> (libunwind_sigtramp_frame_sniffer): Likewise.
>> (libunwind_get_reg_special): Likewise.
>> (libunwind_load): Likewise.
>> * ia64-linux-nat.c (ia64_linux_fetch_register): Likewise.
>> (ia64_linux_store_register): Likewise.
>> (ia64_linux_xfer_partial): Likewise.
>> * ia64-tdep.c (ia64_access_reg): Likewise.
>> (ia64_access_fpreg): Likewise.
>> (ia64_access_rse_reg): Likewise.
>> (ia64_access_rse_fpreg): Likewise.
>
> This is OK. Though ...
>
>> /* Initialize pointers to the dynamic library functions we will use. */
>>
>> - unw_get_reg_p = dlsym (handle, get_reg_name);
>> + unw_get_reg_p = ((int (*) (unw_cursor_t *, unw_regnum_t, unw_word_t *))
>> + dlsym (handle, get_reg_name));
>
> ... I think would be nicer to use typedefs for these.
Installed with that change.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."