This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2][PR gdb/19893] Fix handling of synthetic C++ references


Hi Martin,

This looks mostly good to me.  However ...

On 05/23/2016 05:00 PM, Martin Galvan wrote:

> I've fixed a few things Pedro told me. Notice the printing of '@address' with 'set print object on'
> is not necessarily a bug (the address that'll be shown is the referenced variable's, not something
> like 0x0). If you ask me, I think we can just leave it as a (documented) corner case.

... I still don't know what to think of this -- I simply don't understand it whether
you're doing this because it makes sense, or because doing otherwise would be hard
to do?

- Can you show an example output?  (set print object on/off, etc. whatever might be
  handy to clearly explain that that is about). 
  Pictures are really worth a thousand words.  :-)

- Is this covered by any testcase?  I looked for "object" in the whole patch and
  didn't seem to find it.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]