This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 06/34] Introduce interpreter factories
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 26 May 2016 19:08:14 +0100
- Subject: Re: [PATCH v3 06/34] Introduce interpreter factories
- Authentication-results: sourceware.org; auth=none
- References: <1462538104-19109-1-git-send-email-palves at redhat dot com> <1462538104-19109-7-git-send-email-palves at redhat dot com> <573CC052 dot 6000502 at ericsson dot com>
On 05/18/2016 08:19 PM, Simon Marchi wrote:
> On 16-05-06 08:34 AM, Pedro Alves wrote:
>> diff --git a/gdb/interps.h b/gdb/interps.h
>> index f0badc5..3065fdf 100644
>> --- a/gdb/interps.h
>> +++ b/gdb/interps.h
>> @@ -24,6 +24,17 @@
>>
>> struct ui_out;
>> struct interp;
>> +struct ui;
>> +
>> +typedef struct interp *(*interp_factory_func) (const char *interp,
>
> Nit:
>
> In the functions of this type ({cli,mi,tui}_interp_factory), this parameter is named
> "name", so you could as well name it "name" here as well.
I've done that now.
>
>> + struct ui *ui);
>
> Even in the final result (with all patches applied), none of the factories
> use the ui parameter, is it expected?
I think that at some point I thought of storing a pointer to the UI in
the interp, but then ended up not needing it. I've removed that
parameter now.
I'll post a patch in response to your other email.
Thanks,
Pedro Alves