This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] Add tests for 64bit values in trace-condition.exp
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 27 May 2016 08:36:48 -0400
- Subject: Re: [PATCH 4/4] Add tests for 64bit values in trace-condition.exp
- Authentication-results: sourceware.org; auth=none
- References: <1463504594-4419-1-git-send-email-antoine dot tremblay at ericsson dot com> <1463504594-4419-4-git-send-email-antoine dot tremblay at ericsson dot com> <a1c89256-fc54-5845-1abd-4a18c9c9d531 at redhat dot com>
Pedro Alves writes:
> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
>> This patch adds tests for emit operations with 64 bit values. It takes
>> special care to avoid mistakes that one could make on a 32bit architecture
>> using 64bit values.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.trace/trace-condition.exp: Add 64bit tests.
>> ---
>> gdb/testsuite/gdb.trace/trace-condition.exp | 36 +++++++++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>>
>> diff --git a/gdb/testsuite/gdb.trace/trace-condition.exp b/gdb/testsuite/gdb.trace/trace-condition.exp
>> index 8c770f4..4e129e8 100644
>> --- a/gdb/testsuite/gdb.trace/trace-condition.exp
>> +++ b/gdb/testsuite/gdb.trace/trace-condition.exp
>> @@ -163,4 +163,40 @@ foreach trace_command { "trace" "ftrace" } {
>> test_tracepoints $trace_command "(42 >= 42 ? 0 : 1) == 0" 10
>> test_tracepoints $trace_command "(42 > 21 ? 0 : 1) == 0" 10 18955_i386_failure
>> test_tracepoints $trace_command "\$trace_timestamp >= 0" 10
>> +
>> + #Test operations with 64 bit operands.
>
> Space after # ? More instances below.
Fixed, thanks.
>
> (And same comment as previous patches.)
Yep.