This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING][PATCH v2] AndesTech NDS32 port
- From: Yan-Ting Lin <currygt52 at gmail dot com>
- To: gdb-patches at sourceware dot org
- Date: Sun, 29 May 2016 20:23:07 +0800
- Subject: Re: [PING][PATCH v2] AndesTech NDS32 port
- Authentication-results: sourceware.org; auth=none
Hi GDB maintainers and reviewers,
We have submitted an updated patch in the last post.
Is there any feedback about that patch, or is it acceptable?
2016-05-15 17:39 GMT+08:00 Yan-Ting Lin <currygt52@gmail.com>:
> Hi GDB maintainers and reviewers,
>
> Thanks for the review. After reworking, we submit a new patch here.
>
> The main modification includes:
> 1. Document about NDS32 Features in target description is provided.
> 2. The code to validate FPU registers in target description is rewritten for better match with document.
> 3. Some unused elements due to this rewrite are removed.
> 4. Add missing comments for some functions.
> 5. Use fp_offset to check if reg FP is set in prologue, so unused var use_frame is removed.
> 6. The unnecessary call to register_remote_support_xml() is removed.
> 7. Year in copyright declaration is changed to start from 2013, and that is the year we submitted our first patch.
> 8. Change to top-level configure.ac/configure is removed. They need to be changed manually to enable gdb building.
>
>
> Thanks for your time reviewing our patch again.
>
>
> ChangeLog entries:
>
> gdb/:
> 2016-05-15 Yan-Ting Lin <currygt52@gmail.com>
>
> * Makefile.in: Add NDS32.
> * NEWS: Mention new NDS32 port.
> * configure.tgt: Add NDS32.
> * nds32-tdep.c: New file.
> * nds32-tdep.h: New file.
> * features/Makefile: Add NDS32.
> * features/nds32-core.xml: New file.
> * features/nds32-fpu.xml: New file.
> * features/nds32-system.xml: New file.
> * features/nds32.xml: New file.
> * features/nds32.c: New file (generated).
>
>
> gdb/testsuite/:
> 2016-05-15 Yan-Ting Lin <currygt52@gmail.com>
>
> * gdb.base/float.exp: Add target check for nds32*-*-*.
> * gdb.xml/tdesc-regs.exp: Set core-regs for nds32*-*-*.
>
>
> gdb/doc/:
> 2016-05-15 Yan-Ting Lin <currygt52@gmail.com>
>
> * gdb.texinfo (Standard Target Features): Document NDS32 features.
> (NDS32 Features): New Section.