This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty
- From: Ed Schouten <ed at nuxi dot nl>
- To: DJ Delorie <dj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 29 May 2016 19:24:13 +0200
- Subject: Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty
- Authentication-results: sourceware.org; auth=none
- References: <CABh_MKkAhDsyXGZ51zgwbMPe3EftsVvWf_fPz45QovhaBhPmww at mail dot gmail dot com> <xnbn3o3ibh dot fsf at greed dot delorie dot com>
Hi DJ,
2016-05-29 19:06 GMT+02:00 DJ Delorie <dj@redhat.com>:
> I think the right path to go down is to add libgen.h to the list in
> AC_CHECK_HEADERS for every project that uses basename() (including
> libiberty itself, and binutils, gdb, and gcc), and then everyone who
> uses basename() from libiberty.h would need to include libgen.h *if*
> it's found by configure.
If the users of libiberty have to be explicitly patched up to include
<libgen.h> to get basename(), what's the use of having any of it part
of libiberty in the first place? Wouldn't that practically be the same
as removing basename() from libiberty altogether?
That approach also sounds fine by me, but then again, I'm just an
outsider to this project.
--
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717