This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add method/format information to =record-started
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: markus dot t dot metzger at intel dot com, gdb-patches at sourceware dot org
- Date: Mon, 06 Jun 2016 18:13:41 +0300
- Subject: Re: [PATCH] Add method/format information to =record-started
- Authentication-results: sourceware.org; auth=none
- References: <20160603155220 dot 22286-1-simon dot marchi at ericsson dot com> <A78C989F6D9628469189715575E55B23332EAEF5 at IRSMSX104 dot ger dot corp dot intel dot com> <57557571 dot 7040200 at ericsson dot com> <A78C989F6D9628469189715575E55B23332EB299 at IRSMSX104 dot ger dot corp dot intel dot com> <57557D26 dot 2080009 at ericsson dot com> <A78C989F6D9628469189715575E55B23332EB309 at IRSMSX104 dot ger dot corp dot intel dot com> <57557F4D dot 8020409 at ericsson dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Mon, 6 Jun 2016 09:49:01 -0400
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index dce79a2..253c8e5 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -67,6 +67,11 @@ maint selftest
> including JIT compiling fast tracepoint's conditional expression
> bytecode into native code.
>
> +* MI async record =record-started now includes the method and format used for
> + recording. For example:
> +
> + =record-started,thread-group="i1",method="btrace",format="bts"
> +
> *** Changes in GDB 7.11
This is OK.
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 7e89003..f50582a 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -26423,12 +26423,17 @@ breakpoint commands; @xref{GDB/MI Breakpoint Commands}. The
> Note that if a breakpoint is emitted in the result record of a
> command, then it will not also be emitted in an async record.
>
> -@item =record-started,thread-group="@var{id}"
> +@item =record-started,thread-group="@var{id}",method="@var{method}"[,format="@var{format}"]
> @itemx =record-stopped,thread-group="@var{id}"
> Execution log recording was either started or stopped on an
> inferior. The @var{id} is the @value{GDBN} identifier of the thread
> group corresponding to the affected inferior.
>
> +The @var{method} field indicates the method used to record execution. If the
> +method in use supports multiple recording formats, @var{format} will be present
> +and contain the currently used format. See @xref{Process Record and Replay}
> +for existing method and format values. ^^^
No need for "See" there, as @xref generates that automatically. Or
use "See @ref".
OK for the documentation parts, with the above gotcha fixed.